Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
bobhan1 committed Feb 5, 2025
1 parent 619d468 commit d5a53e6
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 8 deletions.
31 changes: 31 additions & 0 deletions be/src/util/key_util.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

#include "util/key_util.h"

namespace doris {

bool key_is_not_in_segment(Slice key, const KeyBoundsPB& segment_key_bounds,
bool is_segments_key_bounds_truncated) {
Slice maybe_truncated_min_key {segment_key_bounds.min_key()};
Slice maybe_truncated_max_key {segment_key_bounds.max_key()};
return Slice::lhs_is_strictly_less_than_rhs(key, false, maybe_truncated_min_key,
is_segments_key_bounds_truncated) ||
Slice::lhs_is_strictly_less_than_rhs(maybe_truncated_max_key,
is_segments_key_bounds_truncated, key, false);
}
} // namespace doris
9 changes: 1 addition & 8 deletions be/src/util/key_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,6 @@ void encode_key(std::string* buf, const RowType& row, size_t num_keys) {
// we can only know if a key is excluded from the segment
// based on strictly order compare result with segments key bounds
bool key_is_not_in_segment(Slice key, const KeyBoundsPB& segment_key_bounds,
bool is_segments_key_bounds_truncated) {
Slice maybe_truncated_min_key {segment_key_bounds.min_key()};
Slice maybe_truncated_max_key {segment_key_bounds.max_key()};
return Slice::lhs_is_strictly_less_than_rhs(key, false, maybe_truncated_min_key,
is_segments_key_bounds_truncated) ||
Slice::lhs_is_strictly_less_than_rhs(maybe_truncated_max_key,
is_segments_key_bounds_truncated, key, false);
}
bool is_segments_key_bounds_truncated);

} // namespace doris

0 comments on commit d5a53e6

Please sign in to comment.