Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env](compile) open compile_check in some file #45357

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Dec 12, 2024

What problem does this PR solve?

function_rpc.cpp
functions_comparison.h
functions_multi_string_position.cpp
function_split_by_regexp.cpp
function_string.cpp

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Dec 12, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40412 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 23af14df68cfd498a35dd41009ded6df7e99c667, data reload: false

------ Round 1 ----------------------------------
q1	17707	7793	7301	7301
q2	2050	181	179	179
q3	10617	1183	1248	1183
q4	10264	774	713	713
q5	7604	2771	2765	2765
q6	242	148	145	145
q7	987	627	621	621
q8	9251	1860	1974	1860
q9	6658	6475	6546	6475
q10	7004	2308	2361	2308
q11	464	257	257	257
q12	436	227	220	220
q13	17783	3053	3039	3039
q14	248	215	207	207
q15	590	533	522	522
q16	638	586	586	586
q17	1003	523	512	512
q18	7515	6755	6844	6755
q19	1344	1091	1038	1038
q20	475	190	181	181
q21	4081	3268	3231	3231
q22	379	315	314	314
Total cold run time: 107340 ms
Total hot run time: 40412 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7285	7231	7283	7231
q2	334	233	234	233
q3	2998	2897	2869	2869
q4	2008	1763	1729	1729
q5	5528	5508	5482	5482
q6	215	136	139	136
q7	2124	1730	1724	1724
q8	3269	3418	3431	3418
q9	8702	8732	8682	8682
q10	3504	3486	3449	3449
q11	593	504	502	502
q12	762	586	567	567
q13	11316	3016	3071	3016
q14	282	255	267	255
q15	551	496	503	496
q16	682	639	652	639
q17	1838	1620	1587	1587
q18	7908	7468	7549	7468
q19	1673	1524	1598	1524
q20	2078	1818	1826	1818
q21	5388	5276	5229	5229
q22	627	558	548	548
Total cold run time: 69665 ms
Total hot run time: 58602 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.75% (10104/26074)
Line Coverage: 29.69% (84774/285549)
Region Coverage: 28.75% (43514/151345)
Branch Coverage: 25.31% (22103/87340)
Coverage Report: http://coverage.selectdb-in.cc/coverage/23af14df68cfd498a35dd41009ded6df7e99c667_23af14df68cfd498a35dd41009ded6df7e99c667/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 190564 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 23af14df68cfd498a35dd41009ded6df7e99c667, data reload: false

query1	968	397	371	371
query2	6529	2182	2080	2080
query3	6719	214	220	214
query4	33958	23652	23400	23400
query5	4356	468	450	450
query6	286	194	199	194
query7	4650	310	302	302
query8	315	244	235	235
query9	9623	2729	2729	2729
query10	472	261	252	252
query11	17982	15200	15218	15200
query12	162	99	106	99
query13	1669	440	433	433
query14	10464	8158	6923	6923
query15	283	185	181	181
query16	7756	455	454	454
query17	1785	583	574	574
query18	1481	306	305	305
query19	376	164	158	158
query20	122	116	116	116
query21	214	103	106	103
query22	4679	4327	4126	4126
query23	34813	33560	33728	33560
query24	11543	2443	2511	2443
query25	667	381	379	379
query26	1625	149	148	148
query27	2604	285	284	284
query28	7743	2426	2466	2426
query29	956	406	407	406
query30	300	160	150	150
query31	1046	826	842	826
query32	96	58	65	58
query33	809	294	285	285
query34	1037	513	535	513
query35	900	726	748	726
query36	1112	951	983	951
query37	280	75	72	72
query38	4347	4271	4219	4219
query39	1468	1387	1398	1387
query40	282	100	101	100
query41	47	44	45	44
query42	109	100	96	96
query43	553	510	504	504
query44	1277	821	832	821
query45	188	166	167	166
query46	1183	743	722	722
query47	1920	1853	1845	1845
query48	413	329	323	323
query49	1261	392	389	389
query50	824	389	384	384
query51	7211	7094	7069	7069
query52	102	97	93	93
query53	268	190	177	177
query54	1271	415	448	415
query55	80	85	82	82
query56	254	239	245	239
query57	1248	1146	1127	1127
query58	225	221	241	221
query59	3312	3059	3180	3059
query60	279	247	257	247
query61	118	108	104	104
query62	887	673	689	673
query63	218	192	193	192
query64	5106	674	634	634
query65	3273	3172	3239	3172
query66	1281	308	310	308
query67	16010	15496	15646	15496
query68	5514	581	553	553
query69	425	260	267	260
query70	1231	1080	1126	1080
query71	333	313	256	256
query72	6315	4153	4012	4012
query73	800	363	361	361
query74	10408	8963	8927	8927
query75	3424	2683	2675	2675
query76	3467	1098	1108	1098
query77	508	276	341	276
query78	10597	9460	9400	9400
query79	1258	606	611	606
query80	1108	451	460	451
query81	526	238	238	238
query82	1077	118	124	118
query83	239	156	143	143
query84	236	69	72	69
query85	1244	301	373	301
query86	372	317	304	304
query87	4914	4619	4643	4619
query88	3556	2233	2211	2211
query89	418	302	304	302
query90	2022	190	191	190
query91	138	108	102	102
query92	68	51	50	50
query93	1093	549	561	549
query94	983	293	295	293
query95	365	244	247	244
query96	623	278	282	278
query97	2898	2687	2666	2666
query98	215	203	195	195
query99	1646	1337	1303	1303
Total cold run time: 303416 ms
Total hot run time: 190564 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 23af14df68cfd498a35dd41009ded6df7e99c667, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.04	0.06
query3	0.23	0.08	0.07
query4	1.62	0.10	0.11
query5	0.43	0.41	0.40
query6	1.16	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.56	0.58	0.55
query11	0.15	0.11	0.11
query12	0.14	0.10	0.11
query13	0.61	0.60	0.61
query14	2.85	2.75	2.72
query15	0.89	0.82	0.83
query16	0.39	0.36	0.36
query17	1.05	1.05	1.03
query18	0.23	0.21	0.21
query19	1.97	1.84	2.07
query20	0.02	0.01	0.01
query21	15.36	0.60	0.61
query22	2.64	2.05	2.01
query23	16.92	1.11	0.77
query24	2.67	1.65	0.80
query25	0.18	0.05	0.07
query26	0.52	0.14	0.13
query27	0.05	0.04	0.04
query28	10.66	1.10	1.07
query29	12.58	3.25	3.27
query30	0.25	0.07	0.05
query31	2.86	0.39	0.38
query32	3.25	0.47	0.45
query33	2.97	3.09	3.02
query34	16.89	4.43	4.49
query35	4.54	4.50	4.49
query36	0.67	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.53 s
Total hot run time: 32.5 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit b65de37 into apache:master Dec 18, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants