[refactor](exec) refactor analytic operator to improve performance #46181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32773 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 32571 ms |
|
TeamCity be ut coverage result: |
zhangstar333
force-pushed
the
support_range_between
branch
from
c2155d6 to
3cd5904
Compare
|
run buildall |
TPC-H: Total hot run time: 32757 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33981 ms |
TPC-DS: Total hot run time: 194699 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.57 s |
|
run buildall |
TPC-H: Total hot run time: 33810 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 33825 ms |
TPC-DS: Total hot run time: 195996 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.36 s |
|
run buildall |
TPC-H: Total hot run time: 33899 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
zhangstar333
force-pushed
the
support_range_between
branch
from
4dafaea to
3e57bb0
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32743 ms |
TPC-DS: Total hot run time: 192889 ms |
ClickBench: Total hot run time: 31.5 s |
|
run buildall |
TPC-H: Total hot run time: 32219 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 183616 ms |
ClickBench: Total hot run time: 31.27 s |
|
run buildall |
TPC-H: Total hot run time: 32819 ms |
TPC-DS: Total hot run time: 185511 ms |
ClickBench: Total hot run time: 30.75 s |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| _average_size = 0; | ||
| } | ||
|
|
||
| bool is_high_cardinality() const { return _count > 16 && _average_size < 8; } |
There was a problem hiding this comment.
better avoid use magic number
BiteTheDDDDt
approved these changes
Jan 23, 2025
16 tasks
zhangstar333
added a commit
that referenced
this pull request
Jan 26, 2025
### What problem does this PR solve? Problem Summary: the _num_rows_returned have been add twice introduced by #46181, and only in master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Refactoring of Window Function Logic
The previous implementation of the window function operator had complex logic and poor execution performance. In this refactored version, we have categorized the window types and mapped them to corresponding execution functions. The logic is now divided into three major types, with further subdivisions based on specific window types:
No Window
Execution Function:
_get_next_for_partition: [unbounded preceding, unbounded following]
Range Window
Execution Functions:
_get_next_for_partition: [unbounded preceding,unbounded following]
_get_next_for_unbounded_range [RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW]
_get_next_for_range_between [RANGE BETWEEN M PRECEDING AND N FOLLOWING]
Rows Window
Execution Functions:
_get_next_for_partition : [unbounded preceding,unbounded following]
_get_next_for_unbounded_rows: [ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW]
_get_next_for_sliding_rows: [ROWS BETWEEN M PRECEDING AND N FOLLOWING]
Refactoring of Partition Boundary Search
Previously, the boundary search method used a two-level approach:
Firstly need Locate the block position
and then use binary search within the block to find partition boundary
Now, all data is written into a single large column, and binary search is performed directly within this column.
Changes to Operator Dependency Logic
The operator dependency logic has been modified to control the shared buffer:
When the buffer is too full: sink dependency will be blocked, source is running.
When the buffer is empty: sink is resumed, source is blocked.
These changes aim to enhance the functionality and performance of analytic processing and window functions in the pipeline.
and have test in case, this refactor have improve performance 5～10%
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)