Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](MTMV) catch all exception when get mtmvs to avoid plan failed #46474

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Related PR: #28144 #45045

Problem Summary:

if getTable return Table is not MTMV, ClassCastException raised and lead to plan failed.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32931 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e40916d5b5acd6a8e00f8d55804260e0ccfea5d2, data reload: false

------ Round 1 ----------------------------------
q1	17585	6171	6127	6127
q2	2051	319	171	171
q3	10402	1208	752	752
q4	10205	868	432	432
q5	7480	2177	1957	1957
q6	205	178	148	148
q7	900	740	597	597
q8	9250	1354	1192	1192
q9	5201	4911	4952	4911
q10	6741	2306	1845	1845
q11	485	281	253	253
q12	355	359	219	219
q13	17757	3637	3049	3049
q14	253	226	212	212
q15	558	504	491	491
q16	622	643	592	592
q17	585	845	341	341
q18	6963	6453	6407	6407
q19	2197	991	614	614
q20	331	344	212	212
q21	3166	2309	2092	2092
q22	366	343	317	317
Total cold run time: 103658 ms
Total hot run time: 32931 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6243	6180	6126	6126
q2	244	332	238	238
q3	2320	2774	2396	2396
q4	1504	1909	1543	1543
q5	4448	4830	4951	4830
q6	185	182	145	145
q7	2051	1936	1860	1860
q8	2651	2802	2677	2677
q9	7301	7278	7449	7278
q10	3066	3370	2788	2788
q11	578	504	503	503
q12	659	767	613	613
q13	3486	3822	3317	3317
q14	308	292	294	292
q15	575	516	511	511
q16	680	715	650	650
q17	1208	1727	1250	1250
q18	7665	7592	7298	7298
q19	910	1206	1105	1105
q20	1986	2010	1902	1902
q21	5687	5272	4833	4833
q22	618	604	581	581
Total cold run time: 54373 ms
Total hot run time: 52736 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197067 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e40916d5b5acd6a8e00f8d55804260e0ccfea5d2, data reload: false

query1	1289	945	960	945
query2	6459	2308	2335	2308
query3	11095	4802	4817	4802
query4	33046	23830	23504	23504
query5	3727	618	461	461
query6	281	191	181	181
query7	3977	488	321	321
query8	308	252	245	245
query9	9469	2765	2756	2756
query10	444	318	251	251
query11	17984	15381	15204	15204
query12	174	115	106	106
query13	1578	515	396	396
query14	10802	6968	6826	6826
query15	246	222	208	208
query16	7239	626	511	511
query17	1555	774	578	578
query18	1944	391	329	329
query19	211	186	154	154
query20	131	120	110	110
query21	204	127	103	103
query22	4468	4468	4652	4468
query23	34868	33577	33643	33577
query24	6426	2327	2265	2265
query25	481	463	401	401
query26	784	282	157	157
query27	2026	493	331	331
query28	5470	2522	2535	2522
query29	580	539	407	407
query30	205	180	152	152
query31	991	941	849	849
query32	71	62	53	53
query33	478	350	308	308
query34	753	862	524	524
query35	810	869	745	745
query36	1024	1063	979	979
query37	142	100	76	76
query38	4406	4208	4118	4118
query39	1495	1672	1471	1471
query40	206	112	100	100
query41	47	44	42	42
query42	123	104	99	99
query43	524	537	496	496
query44	1378	839	863	839
query45	194	185	195	185
query46	870	1056	656	656
query47	2012	2028	1946	1946
query48	384	402	319	319
query49	718	496	416	416
query50	645	672	393	393
query51	7238	7170	7085	7085
query52	103	112	88	88
query53	218	258	202	202
query54	469	503	400	400
query55	81	83	83	83
query56	251	279	247	247
query57	1265	1228	1206	1206
query58	271	236	242	236
query59	3267	3398	3312	3312
query60	315	271	265	265
query61	130	128	127	127
query62	881	848	751	751
query63	233	190	195	190
query64	3399	1025	667	667
query65	3329	3249	3256	3249
query66	768	417	312	312
query67	16548	15896	15634	15634
query68	7893	709	525	525
query69	486	291	251	251
query70	1239	1184	1167	1167
query71	440	280	246	246
query72	6289	3903	3924	3903
query73	656	765	457	457
query74	10481	9181	8910	8910
query75	4055	3144	2656	2656
query76	3665	1199	777	777
query77	760	372	281	281
query78	10849	10217	9335	9335
query79	3234	817	585	585
query80	653	534	426	426
query81	479	277	235	235
query82	605	149	199	149
query83	160	160	153	153
query84	255	86	70	70
query85	787	378	302	302
query86	352	328	300	300
query87	4501	4570	4365	4365
query88	4203	2225	2215	2215
query89	417	312	296	296
query90	1904	184	187	184
query91	130	137	102	102
query92	64	56	56	56
query93	1001	713	531	531
query94	644	390	290	290
query95	334	265	247	247
query96	490	606	276	276
query97	2913	3021	2894	2894
query98	225	210	201	201
query99	1697	1595	1435	1435
Total cold run time: 295369 ms
Total hot run time: 197067 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e40916d5b5acd6a8e00f8d55804260e0ccfea5d2, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.44	0.42	0.41
query6	1.17	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.52	0.51
query10	0.55	0.56	0.55
query11	0.15	0.11	0.10
query12	0.13	0.11	0.11
query13	0.61	0.61	0.61
query14	2.73	2.85	2.74
query15	0.90	0.84	0.84
query16	0.39	0.39	0.38
query17	1.09	0.98	1.06
query18	0.22	0.20	0.20
query19	1.92	1.85	2.04
query20	0.01	0.01	0.01
query21	15.37	0.90	0.60
query22	0.74	0.78	0.58
query23	15.37	1.43	0.55
query24	2.61	0.62	1.85
query25	0.27	0.16	0.14
query26	0.19	0.15	0.14
query27	0.09	0.05	0.04
query28	14.25	1.55	1.05
query29	12.55	3.99	3.30
query30	0.25	0.09	0.06
query31	2.84	0.58	0.38
query32	3.23	0.56	0.48
query33	3.28	3.14	3.15
query34	16.61	5.17	4.52
query35	4.54	4.47	4.59
query36	0.64	0.52	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.22 s
Total hot run time: 31.08 s

@morrySnow morrySnow merged commit 5e8105b into apache:master Jan 7, 2025
28 checks passed
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@morrySnow morrySnow deleted the fix_get_mtmv_failed branch January 7, 2025 07:57
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
…#46474)

### What problem does this PR solve?

Related PR: #28144 #45045

Problem Summary:
if getTable return Table is not MTMV, ClassCastException raised and lead
to plan failed.
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
…#46474)

### What problem does this PR solve?

Related PR: #28144 #45045

Problem Summary:
if getTable return Table is not MTMV, ClassCastException raised and lead
to plan failed.
morrySnow added a commit that referenced this pull request Jan 7, 2025
morrySnow added a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants