Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](regression)Fix unstable compaction related cases (#46920) #47002

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[fix](regression)Fix unstable compaction related cases (#46920) #47002

merged 1 commit into from
Jan 15, 2025

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Jan 15, 2025

bp #46920

@qidaye
Copy link
Contributor Author

qidaye commented Jan 15, 2025

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qidaye
[fix](regression)Fix unstable compaction related cases (apache#46920)
fd34e05 
Related PR: apache#45761

Problem Summary:

1. Added `wait_for_build_index_on_partition_finish` calls to ensure
indexes are built before triggering compaction.

2. When we do index compaction fault injection test, compaction status
`e-6010` is expected sometimes. Added an `ignored_errors` parameter to
the `trigger_and_wait_compaction` method, allowing specific errors to be
ignored during compaction.
@qidaye qidaye force-pushed the pick_fix_compaction_case branch from 00e4053 to fd34e05 Compare January 15, 2025 02:40
@qidaye
Copy link
Contributor Author

qidaye commented Jan 15, 2025

run buildall

airborne12
airborne12 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

shuke987
shuke987 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit ed78d99 into apache:branch-3.0 Jan 15, 2025
24 of 25 checks passed
@qidaye qidaye deleted the pick_fix_compaction_case branch January 15, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@shuke987 shuke987 shuke987 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qidaye @hello-stephen @airborne12 @shuke987