-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRILL-8260: Added Platforms (linux/amd64,linux/arm64) on Docker Build #2951
base: master
Are you sure you want to change the base?
Conversation
@ionutpopa Thanks for this. Forgive the question as I'm not a Docker expert but do we need to add |
@cgivre IMHO we could keep only the linux platforms as the original docker works on Windows just fine. |
@ionutpopa |
The Linux container images will work for Windows users through WSL or Hyper-V which is how they must already be running most of their conatiners. Actually building on a Windows container base image would require deeper changes from us, I think, and someone would have to check the license to see whether we'd be free to redistribute the Microsoft binaries included as an Apache project. |
In that case, LGTM +1 |
Marked as draft until we've triggered a test in Docker Hub (which I'll do). |
@jnturton The ci/dockercloud-stage failed and when checking the details I saw |
@ionutpopa, below is what happened in Docker Hub.
We can read up on and try
EDIT: I've commented out the |
I got a build going after putting
|
DRILL-8260: added platforms (linux/amd64,linux/arm64) on docker build
Description
Added the following platforms in the build file from the hooks folder: linux/amd64 and linux/arm64
Documentation
Now Apache Drill Docker image is available for both linux/arm64 and linux/amd64
Testing
Built images locally