Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2192] Add temporal worker metrics support #4095

Conversation

abhishekmjain
Copy link
Contributor

@abhishekmjain abhishekmjain commented Feb 4, 2025

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Added Micrometer-OTLP bridge for emitting temporal worker metrics.
    Added relevant configs along with their default values.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • testGetDimensions
  • testGetDimensionsEmptyConfig
  • testGetOtlpConfig

Also performed local project testing

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@abhishekmjain abhishekmjain force-pushed the add-temporal-worker-metrics-support branch from 62d1211 to 41da809 Compare February 4, 2025 14:23
@abhishekmjain abhishekmjain marked this pull request as ready for review February 4, 2025 14:26
@abhishekmjain abhishekmjain force-pushed the add-temporal-worker-metrics-support branch from 41da809 to a5202b2 Compare February 4, 2025 14:38
Copy link
Contributor

@vsinghal85 vsinghal85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, resolved few queries related to change offline

@abhishekmjain abhishekmjain merged commit adef734 into apache:master Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants