Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove use of Filter from public APIs #266

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

xushiyan
Copy link
Member

Description

Replace Filter from being used as public API args. Use tuple of str instead for simpler invocation.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change python Related to Python codebase rust Related to Rust codebase labels Jan 26, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 26, 2025
@xushiyan xushiyan changed the title refactor: remove use of Filter from public APIs` refactor: remove use of Filter from public APIs Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (a8df9a1) to head (72cfe39).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/mod.rs 70.37% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   91.26%   91.25%   -0.02%     
==========================================
  Files          41       41              
  Lines        2015     2024       +9     
==========================================
+ Hits         1839     1847       +8     
- Misses        176      177       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit d257a21 into apache:main Jan 26, 2025
9 of 10 checks passed
@xushiyan xushiyan deleted the refactor-filter-api branch January 26, 2025 20:20
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python codebase refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant