[HUDI-7374] Fix flaky test concurrent compaction test #12657
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davis-Zhang-Onehouse
force-pushed
the
HUDI-7374
branch
from
c59498d to
194c5eb
Compare
nsivabalan
approved these changes
Jan 17, 2025
Davis-Zhang-Onehouse
force-pushed
the
HUDI-7374
branch
from
c6c6a47 to
0f194b9
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-7374
branch
from
0f194b9 to
d69ad84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The culprit leads to validation issue is because instead of extracting the commit time from the data file and compare, we just treat the whole file name as a string and check if the string contains the commit instant time string. This causes issue if the commit instant time string is short (like "002") as the file name is generated with UUID and it can contain this string by chance.
The fix is we explicitly extract the commit time from the file name and compare, this eliminates any ambiguity of the validation we are doing.
Also we should write more informative error message, containing as many context on what we validated as possible. It saves tons of time reproducing the issue.
Impact
fixed flaky test
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist