[HUDI-8949] Relaxing checkpoint validation for HoodieStreamerSources #12752
+40
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
changed the title
nsivabalan
force-pushed
the
relaxCheckpointValidation
branch
from
174e862 to
514fd22
Compare
yihua
reviewed
Jan 31, 2025
| @@ -132,7 +129,7 @@ public void verifyLastInstantCommitMetadata(Map<String, String> expectedMetadata | |||
| * - Verifies commit metadata still uses checkpoint V1 format | |||
| * - Verifies final checkpoint="30" | |||
| */ | |||
| @ParameterizedTest | |||
| /*@ParameterizedTest | |||
There was a problem hiding this comment.
Let's annotate this as @Disabled and add a TODO with a follow-up JIRA.
yihua
approved these changes
Jan 31, 2025
|
@hudi-bot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Checkpoint version is also a func of target table version. But one of the recent validations we aded started failing for custom sources when we try creating table with version 6. Relaxing the constraint for now. We will follow up w/ a proper fix later.
Impact
Checkpoint version is also a func of target table version. But one of the recent validations we aded started failing for custom sources when we try creating table with version 6. Relaxing the constraint for now. We will follow up w/ a proper fix later.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist