Skip to content

Commit

Permalink
Fix BREAKING_CHANGE string detection in commit msg / PR body
Browse files Browse the repository at this point in the history
  • Loading branch information
hubcio committed Mar 2, 2024
1 parent d79746c commit b859c9a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/backwards_compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ jobs:
echo "Commit message: $COMMIT_MSG"
if echo "$COMMIT_MSG" | grep -q "BREAKING_CHANGE"; then
echo "skip=true" >> $GITHUB_OUTPUT
echo "skip=true, 'BREAKING_CHANGE' found in commit message"
else
echo "skip=false" >> $GITHUB_OUTPUT
echo "skip=false, 'BREAKING_CHANGE' not found in commit message"
fi
- name: Check for BREAKING_CHANGE in pull request body
Expand All @@ -34,8 +36,10 @@ jobs:
echo "Pull Request body: $PR_MSG_BODY"
if [[ "$PR_MSG_BODY" == *"BREAKING_CHANGE"* ]]; then
echo "skip=true" >> $GITHUB_OUTPUT
echo "skip=true, 'BREAKING_CHANGE' found in pull request body"
else
echo "skip=false" >> $GITHUB_OUTPUT
echo "skip=false, 'BREAKING_CHANGE' not found in pull request body"
fi
build_and_test:
Expand All @@ -44,6 +48,8 @@ jobs:
if: ${{ needs.check_commit_message.outputs.should_skip != 'true' }}
steps:
- run: echo "${{ needs.check_commit_message.outputs.should_skip }}"
- run: echo "${{ needs.check_commit_message.outputs.should_skip }}"
- run: echo "${{ needs.check_commit_message.outputs.should_skip }}"

- uses: actions/checkout@v4
with:
Expand Down

0 comments on commit b859c9a

Please sign in to comment.