Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-22669 Change maven.compiler.source to 11 #11432

Conversation

timoninmaxim
Copy link
Member

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.

@alex-plekhanov
Copy link
Contributor

If it's a final patch for moving to java 11 we should also:

  • Change ./bin files to check correct java version (11 instead of 8, for example ignite.bat/functions.sh)
  • Remove java-8 profile from tools/pom.xml
  • Remove java8 directory from tools module
  • Change JDK verrsion in all Dockerfiles
  • Change JDK in deb/rpm packages
  • Perhaps clean some code for old java versions (for example, GridCleaner.PRE_JAVA9_CLEANER_CLASS_NAME)
  • Fix cpp/dotnet platforms to use java 11
  • ...

@timoninmaxim timoninmaxim changed the base branch from master to IGNITE-22996__epic_jdk_11 August 15, 2024 14:43
Copy link

@nizhikov
Copy link
Contributor

nizhikov commented Sep 3, 2024

IMAGE 2024-09-03 16:28:44
IMAGE 2024-09-03 16:28:48
IMAGE 2024-09-03 16:28:51

We still have some links to the older java docs.
Do we want to fix them?

@timoninmaxim timoninmaxim merged commit a5d23cb into apache:IGNITE-22996__epic_jdk_11 Sep 3, 2024
5 of 6 checks passed
@timoninmaxim timoninmaxim deleted the IGNITE-22669__java_source_11 branch September 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants