IGNITE-23333 СDC is no longer experimental #11567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luchnikovbsk
changed the title
|
Please also change org.apache.ignite.cdc.TypeMapping |
petrov-mg
approved these changes
Oct 24, 2024
timoninmaxim
requested changes
Jan 29, 2025
| @@ -65,7 +64,6 @@ | |||
| * @see CdcEvent | |||
| * @see CacheEntryVersion | |||
| */ | |||
| @IgniteExperimental | |||
There was a problem hiding this comment.
Class should not have references to internal packages (CdcMain).
|
|
||
| import static org.apache.ignite.internal.IgniteComponentType.SPRING; | ||
|
|
||
| /** | ||
| * Utility class to load {@link CdcMain} from Spring XML configuration. | ||
| */ | ||
| @IgniteExperimental | ||
| public class CdcLoader { |
There was a problem hiding this comment.
Whether this class should be in internal package?
| @@ -62,7 +61,6 @@ | |||
| * @see CdcConsumer#onEvents(Iterator) | |||
| * @see CdcConsumerState#saveCdcMode(CdcMode) | |||
| */ | |||
| @IgniteExperimental | |||
There was a problem hiding this comment.
CdcManager is still experimental API. This class is responsible for Online CDC, that is experimtenal
| @@ -450,14 +450,12 @@ If the file name isn't specified the output file name is: '<typeId>.bin': | |||
| Finalize partitions update counters: | |||
| control.(sh|bat) --consistency finalize | |||
|
|
|||
| [EXPERIMENTAL] | |||
There was a problem hiding this comment.
Move non-experimental commands before experimental
luchnikovbsk
force-pushed
the
master_IGNITE-23333
branch
3 times, most recently
from
388326d to
8a7b527
Compare
luchnikovbsk
force-pushed
the
master_IGNITE-23333
branch
from
8a7b527 to
93b8b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Online CDC still experimental
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.