fix(config-ui): some bugs for transformation (#6313)

* fix(config-ui): copywriting errors * fix(config-ui): the transformation default value * fix(config-ui): adjust the copywriting in bitbucket transformation
apache · Oct 25, 2023 · b52a936 · b52a936
1 parent 98b6062
commit b52a936
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 15 deletions.
diff --git a/config-ui/src/plugins/register/bitbucket/transformation.tsx b/config-ui/src/plugins/register/bitbucket/transformation.tsx
@@ -158,10 +158,7 @@ export const BitbucketTransformation = ({ entities, transformation, setTransform
           </div>
           <div className="text">
             <Checkbox checked={useCustom} onChange={handleChangeUseCustom} />
-            <span>
-              Convert a BitBucket Pipeline to a DevLake Deployment when its branch/tag name or one of its pipeline
-              steps’ names
-            </span>
+            <span>Convert a BitBucket Pipeline to a DevLake Deployment when its branch/tag name</span>
           </div>
           <div className="sub-text">
             <span>matches</span>

diff --git a/config-ui/src/plugins/register/github/config.tsx b/config-ui/src/plugins/register/github/config.tsx
@@ -113,8 +113,9 @@ export const GitHubConfig: PluginConfigType = {
       issuePriority: '(highest|high|medium|low|p0|p1|p2|p3)',
       issueComponent: 'component(.*)',
       issueSeverity: 'severity(.*)',
-      deploymentPattern: '(deploy|push-image)',
-      productionPattern: 'prod(.*)',
+      envNamePattern: '(?i)prod(.*)',
+      deploymentPattern: '',
+      productionPattern: '',
       prType: 'type(.*)',
       prComponent: 'component(.*)',
       prBodyClosePattern:

diff --git a/config-ui/src/plugins/register/github/transformation.tsx b/config-ui/src/plugins/register/github/transformation.tsx
@@ -197,7 +197,7 @@ export const GitHubTransformation = ({ entities, transformation, setTransformati
           </p>
           <div className="text">
             <Checkbox disabled checked />
-            <span>Convert a GitHub Workflow to a DevLake Deployment </span>
+            <span>Convert a GitHub Deployment to a DevLake Deployment </span>
           </div>
           <div className="sub-text">
             <span>If its environment name matches</span>
@@ -216,10 +216,12 @@ export const GitHubTransformation = ({ entities, transformation, setTransformati
           </div>
           <div className="text">
             <Checkbox checked={useCustom} onChange={handleChangeUseCustom} />
-            <span>Convert a GitHub Workflow to a DevLake Deployment</span>
+            <span>Convert a GitHub workflow run as a DevLake Deployment when: </span>
           </div>
           <div className="sub-text">
-            <span>Its branch/tag name or one of its jobs matches</span>
+            <span>
+              The name of the <strong>GitHub workflow run</strong> or <strong> one of its jobs</strong> matches
+            </span>
             <InputGroup
               style={{ width: 180, margin: '0 8px' }}
               placeholder="(deploy|push-image)"
@@ -248,7 +250,7 @@ export const GitHubTransformation = ({ entities, transformation, setTransformati
                 })
               }
             />
-            <span>, this Deployment is a ‘Production Deployment’</span>
+            <span>, this deployment is a ‘Production Deployment’</span>
             <HelpTooltip content="If you leave this field empty, all Deployments will be tagged as in the Production environment. " />
           </div>
         </S.CICD>

diff --git a/config-ui/src/plugins/register/gitlab/config.tsx b/config-ui/src/plugins/register/gitlab/config.tsx
@@ -75,8 +75,9 @@ export const GitLabConfig: PluginConfigType = {
   scopeConfig: {
     entities: ['CODE', 'TICKET', 'CODEREVIEW', 'CROSS', 'CICD'],
     transformation: {
-      deploymentPattern: '(deploy|push-image)',
-      productionPattern: 'prod(.*)',
+      envNamePattern: '(?i)prod(.*)',
+      deploymentPattern: '',
+      productionPattern: '',
     },
   },
 };
diff --git a/config-ui/src/plugins/register/gitlab/transformation.tsx b/config-ui/src/plugins/register/gitlab/transformation.tsx
@@ -72,7 +72,7 @@ export const GitLabTransformation = ({ entities, transformation, setTransformati
           </p>
           <div className="text">
             <Checkbox disabled checked />
-            <span>Convert a GitLab Deployment to a DevLake Deployment</span>
+            <span>Convert a GitLab Deployment to a DevLake Deployment </span>
           </div>
           <div className="sub-text">
             <span>If its environment name matches</span>
@@ -91,10 +91,12 @@ export const GitLabTransformation = ({ entities, transformation, setTransformati
           </div>
           <div className="text">
             <Checkbox checked={useCustom} onChange={handleChangeUseCustom} />
-            <span>Convert a GitLab Pipeline as a DevLake Deployment when:</span>
+            <span>Convert a GitLab Pipeline as a DevLake Deployment when: </span>
           </div>
           <div className="sub-text">
-            <span>Its branch/tag name or one of its jobs matches</span>
+            <span>
+              Its branch/tag name or <strong>one of its jobs</strong> matches
+            </span>
             <InputGroup
               style={{ width: 180, margin: '0 8px' }}
               placeholder="(deploy|push-image)"