fix: bitbucket search remote scopes not functional #6312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please paraphrase the placeholder of the search input to: "Enter the keywords to search for repositories that you have read access" |
abeizn
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing search remote scopes of the Bitbucket plugin require
gidparameter to work which is not practical.This PR uses another API to achieve the goal, however, for the API to filter the result, the
roleparameter is required, so it is impossible to search PUBLIC Repos.To avoid confusion, we should notify users on the config-ui that searching is only for "repositories to which the user has explicit read access"
Screenshots