Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling checkLoginIframe on KC client init #1115

Closed
wants to merge 2 commits into from

Conversation

rafaeltuelho
Copy link

This PR tries to solve an issue I found when running the management console on Docker (docker-compose) on Mac OS.
The issue is discussed in this zulipchat topic: https://kie.zulipchat.com/#narrow/stream/232676-kogito/topic/mgmt-console.20with.20keycloack

From my research Keycloak enforces by default a Security Policy that affects the way the kogito console initializes KC JavaScript adapter. This is better explained here https://www.keycloak.org/docs/latest/securing_apps/#session-status-iframe.

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • Pull Request
    Please add comment: Jenkins retest this

  • Quarkus LTS checks
    Please add comment: Jenkins run LTS

  • Native checks
    Please add comment: Jenkins run native

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

11 similar comments
@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 16, 2021

Can one of the admins verify this patch?

Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @rafaeltuelho

@pefernan
Copy link
Contributor

jenkins retest this please

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@domhanak
Copy link

domhanak commented Feb 9, 2023

@pefernan @AjayJagan @Sara4994 Could you please check this and see if this is still relevant? Thanks

@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 9, 2023

(tests) - kogito-springboot-examples job #188 was: UNSTABLE
Possible explanation: This should be test failures

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-apps.tests.downstream.kogito-springboot-examples/188/display/redirect

Test results:

  • PASSED: 128
  • FAILED: 1

Those are the test failures:

org.kie.kogito.springboot.outbox.OutboxIT.(?) java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (localhost ports: [8080, 32789] should be listening)
at org.kie.kogito.springboot.outbox.OutboxIT.before(OutboxIT.java:86)
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (localhost ports: [8080, 32789] should be listening)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@domhanak
Copy link

domhanak commented Apr 8, 2024

closing as outdated, please reopen if still relevant @rafaeltuelho @pefernan

@domhanak domhanak closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants