-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disabling checkLoginIframe on KC client init #1115
Conversation
Can one of the admins verify this patch? |
11 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
87c0ab2
to
b9e010e
Compare
b9e010e
to
5ba3022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks @rafaeltuelho
jenkins retest this please |
Kudos, SonarCloud Quality Gate passed!
|
@pefernan @AjayJagan @Sara4994 Could you please check this and see if this is still relevant? Thanks |
(tests) - kogito-springboot-examples job Test results:
Those are the test failures: org.kie.kogito.springboot.outbox.OutboxIT.(?)java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (localhost ports: [8080, 32789] should be listening)at org.kie.kogito.springboot.outbox.OutboxIT.before(OutboxIT.java:86) Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (localhost ports: [8080, 32789] should be listening) |
Kudos, SonarCloud Quality Gate passed! |
closing as outdated, please reopen if still relevant @rafaeltuelho @pefernan |
This PR tries to solve an issue I found when running the management console on Docker (docker-compose) on Mac OS.
The issue is discussed in this zulipchat topic: https://kie.zulipchat.com/#narrow/stream/232676-kogito/topic/mgmt-console.20with.20keycloack
From my research Keycloak enforces by default a Security Policy that affects the way the kogito console initializes KC JavaScript adapter. This is better explained here https://www.keycloak.org/docs/latest/securing_apps/#session-status-iframe.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
Pull Request
Please add comment: Jenkins retest this
Quarkus LTS checks
Please add comment: Jenkins run LTS
Native checks
Please add comment: Jenkins run native