[Fix #2177] Merge ProcessDefinitionEvent metadata

[fjtirado]

Fix #2177

[kie-ci3]

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2178 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2178/3/display/redirect

Test results:

• PASSED: 1586
• FAILED: 36

Those are the test failures:

org.kie.kogito.index.inmemory.KogitoDevServiceTest.testDataIndexDevService

io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step org.kie.kogito.quarkus.serverless.workflow.deployment.ServerlessWorkflowDevServicesProcessor#startDataIndexDevService threw an exception: java.lang.RuntimeException: Failed to start Kogito Data Index Dev Services
at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.startDataIndexDevService(AbstractDevServicesProcessor.java:129)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:840)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image org.kie.kogito/data-index-service-inmemory:999-SNAPSHOT
at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.lambda$startDataIndex$2(AbstractDevServicesProcessor.java:203)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.startDataIndex(AbstractDevServicesProcessor.java:208)
at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.startDataIndexDevService(AbstractDevServicesProcessor.java:119)
... 11 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image org.kie.kogito/data-index-service-inmemory:999-SNAPSHOT
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)
at org.kie.kogito.quarkus.workflow.deployment.AbstractDevServicesProcessor.lambda$startDataIndex$2(AbstractDevServicesProcessor.java:199)
... 14 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)
... 16 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 17 more
Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 1
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533)
... 19 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for URL to be accessible (http://172.18.0.1:55296/q/health/ready should return HTTP [200])
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:320)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)
... 19 more
Caused by: org.rnorth.ducttape.TimeoutException: Timeout waiting for result with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:54)
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:252)
... 22 more
Caused by: java.lang.RuntimeException: java.net.ConnectException: Connection refused
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.lambda$null$6(HttpWaitStrategy.java:312)
at org.rnorth.ducttape.ratelimits.RateLimiter.doWhenReady(RateLimiter.java:27)
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.lambda$waitUntilReady$7(HttpWaitStrategy.java:257)
at org.rnorth.ducttape.unreliables.Unreliables.lambda$retryUntilSuccess$0(Unreliables.java:43)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.net.ConnectException: Connection refused
at java.base/sun.nio.ch.Net.connect0(Native Method)
at java.base/sun.nio.ch.Net.connect(Net.java:579)
at java.base/sun.nio.ch.Net.connect(Net.java:568)
at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:593)
at java.base/java.net.Socket.connect(Socket.java:633)
at java.base/java.net.Socket.connect(Socket.java:583)
at java.base/sun.net.NetworkClient.doConnect(NetworkClient.java:183)
at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:533)
at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:638)
at java.base/sun.net.www.http.HttpClient.(HttpClient.java:281)
at java.base/sun.net.www.http.HttpClient.New(HttpClient.java:386)
at java.base/sun.net.www.http.HttpClient.New(HttpClient.java:408)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1309)
at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1242)
at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1128)
at java.base/sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:1057)
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.lambda$null$6(HttpWaitStrategy.java:274)
... 7 more

org.kie.kogito.index.inmemory.ProcessDataIndexInMemoryIT.testProcessInstanceEvents

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.DataIndexInMemoryQuarkusTestResource

org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlHttpIT.testProcessInstanceEvents

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource

org.kie.kogito.index.service.InmemoryPostgreSqlIndexingServiceIT.(?)

java.lang.ExceptionInInitializerError

org.kie.kogito.index.service.KeycloakInmemoryPostgreSqlIndexingServiceIT.testUnauthorizedUserAccess

java.lang.ExceptionInInitializerError

org.kie.kogito.index.service.KeycloakPostgreSqlIndexingServiceIT.testUnauthorizedUserAccess

java.lang.ExceptionInInitializerError

org.kie.kogito.index.service.PostgreSqlIndexingServiceIT.(?)

java.lang.ExceptionInInitializerError

org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEvent

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.mapper.JobEntityMapperIT.testMapToModel

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.H2JobEntityQueryIT.testJobQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.H2ProcessDefinitionEntityQueryIT.testProcessDefinitionQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.H2ProcessInstanceEntityQueryIT.testProcessInstanceQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.H2UserTaskInstanceEntityQueryIT.testUserTaskInstanceQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.PostgreSQLJobEntityQueryIT.testJobQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.PostgreSQLProcessDefinitionEntityQueryIT.testProcessDefinitionQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.PostgreSQLProcessInstanceEntityQueryIT.testProcessInstanceQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.query.PostgreSQLUserTaskInstanceEntityQueryIT.testUserTaskInstanceQuery

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.storage.H2JobStorageIT.testJobEntity

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.storage.PostgreSQLJobStorageIT.testJobEntity

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.storage.PostgreSQLProcessDefinitionStorageIT.testProcessDefinitionEntity

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.storage.PostgreSQLProcessInstanceStorageIT.testProcessInstanceErrorEvent

java.lang.ExceptionInInitializerError

org.kie.kogito.index.jdbc.storage.PostgreSQLUserTaskInstanceStorageIT.testUserTaskInstanceEntity

java.lang.ExceptionInInitializerError

org.kie.kogito.index.postgresql.reporting.ProcessInstanceVariableMappingIT.testProcessInstanceVariableMapping

java.lang.ExceptionInInitializerError

org.kie.kogito.index.postgresql.mapper.JobEntityMapperIT.testMapToModel

java.lang.ExceptionInInitializerError

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InfinispanQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon

java.lang.ExceptionInInitializerError

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexPersistenceTest.testDataIndexAddon

java.lang.ExceptionInInitializerError

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon

java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InfinispanQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InMemoryQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.InMemoryQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.JPAQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexIT.testDataIndexAddon

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

[gmunozfe]

Looks good to me, just a single comment to document merges with null value.
Feel free to incorporate these tests for better coverage fjtirado#2

Great work @fjtirado !