Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix_#2183] Removing quarkus test utils from common module #2184

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Feb 3, 2025

Fix #2183

There was some code in the common test library that was incorrectly referencing quarkus

@fjtirado fjtirado marked this pull request as draft February 3, 2025 11:33
@fjtirado fjtirado force-pushed the Fix_#2183 branch 2 times, most recently from 309c8cd to 8996708 Compare February 3, 2025 12:46
@fjtirado fjtirado marked this pull request as ready for review February 3, 2025 15:59
@fjtirado fjtirado requested a review from gmunozfe February 5, 2025 10:28
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a suggestion but up to you, well done @fjtirado

@fjtirado fjtirado merged commit cc3c6cd into apache:main Feb 5, 2025
10 of 11 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-apps that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus dependencies are included in SpringBoot IT test
3 participants