[Fix #2193] ExecuteAfter mutation to return Json #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other mutations are still returning String to keep backward compatibility, although we probably should change them too
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2194 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2194/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.index.addon.api.KogitoAddonRuntimeClientImplTest.testExecuteAfterSuccessclass java.lang.Object cannot be cast to class org.kie.kogito.Model (java.lang.Object is in module java.base of loader 'bootstrap'; org.kie.kogito.Model is in unnamed module of loader 'app') |
wmedvede
approved these changes
Feb 20, 2025
| } else { | ||
| LOGGER.trace("Error {}", logMessage); | ||
| LOGGER.info("Error {}", logMessage); |
There was a problem hiding this comment.
If we are logging an error, why not to use do LOGGER.error ?
rgdoliveira
pushed a commit
to rgdoliveira/kogito-apps
that referenced
this pull request
Feb 24, 2025
* [Fix apache#2193] ExecuteAfter mutation to return Json Other mutations are still returning String to keep backward compatibility, although we probably should change them too * [Fix apache#2193] Walters comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2193
Other mutations are still returning String to keep backward compatibility, although we probably should change them too