kie-issues#776: automate PR merge into protected branches #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
Merged
Merged
Merged
Merged
Merged
cimbalek
reviewed
May 10, 2024
| @@ -133,3 +130,10 @@ void sendNotification(String body) { | |||
| void sendErrorNotification() { | |||
| sendNotification("Job #${BUILD_NUMBER} was: **${currentBuild.currentResult}**\nPlease look here: ${BUILD_URL}") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Three times the same function might be worth considering to move it into library. But let's not delay merging this PR by it.
cimbalek
approved these changes
May 10, 2024
baldimir
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of:
Other related PRs:
Replacing old approach to merge PRs: merge locally + push into remote
New behavior relies on gh cli directly to approve and merge PR.