Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1551] Deadlines for Human Task #3752

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

elguardian
Copy link
Contributor

@apache apache deleted a comment from kie-ci3 Oct 26, 2024
@apache apache deleted a comment from kie-ci3 Oct 26, 2024
@apache apache deleted a comment from kie-ci3 Oct 31, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 7, 2024
@apache apache deleted a comment from kie-ci3 Nov 11, 2024
@apache apache deleted a comment from kie-ci3 Nov 13, 2024
@pefernan pefernan self-requested a review November 15, 2024 08:09
@apache apache deleted a comment from kie-ci3 Nov 15, 2024



/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed



create table jbpm_user_tasks_reassignment_timer (
task_id varchar(50) not null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind align the column types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligned

@@ -29,7 +36,6 @@
})
@AssociationOverride(name = "taskInstance",
joinColumns = @JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "jbpm_user_tasks_outputs_tid")))
@IdClass(TaskDataEntityPK.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we need:
@IdClass(TaskNamedDataEntityPK.class)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some IT tests need to be fixed
Approved when green

@apache apache deleted a comment from kie-ci3 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlines for Human Task
3 participants