Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-11678][SDK] Optimize the ProxyClientConfig class #11679

Merged
merged 1 commit into from
Jan 19, 2025
Merged

[INLONG-11678][SDK] Optimize the ProxyClientConfig class #11679

merged 1 commit into from
Jan 19, 2025
+1,688 −905

Conversation

gosonzhang
Copy link
Contributor

Fixes #11678

  1. Divide ProxyClientConfig into two subclasses, TcpMsgSenderConfig and HttpMsgSenderConfig, according to different data reporting protocols
  2. Adjust the naming of some configuration parameters, add value range checks, and add configuration content output, clone, and comparison operation functions;
  3. Add unit test cases for configuration classes
  4. Adjust the implementation logic of each module using configuration parameters to initialize and obtain configuration

@gosonzhang gosonzhang merged commit 5fcc384 into apache:master Jan 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloyszhang aloyszhang aloyszhang approved these changes

@vernedeng vernedeng vernedeng approved these changes

@justinwwhuang justinwwhuang justinwwhuang approved these changes

@luchunliang luchunliang luchunliang approved these changes

Assignees
No one assigned
Labels
component/agent component/sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][SDK] Optimize the ProxyClientConfig class
5 participants
@gosonzhang @luchunliang @justinwwhuang @vernedeng @aloyszhang