Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11680][SDK] Optimize metric-related implementation #11708

Merged
merged 2 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.inlong.sdk.dataproxy.config;

import org.apache.inlong.sdk.dataproxy.metric.MetricDataHolder;

import java.util.List;

/**
Expand All @@ -29,4 +31,6 @@ public interface ConfigHolder {
void updateAllowedMaxPkgLength(int maxPkgLength);

void updateProxyNodes(boolean nodeChanged, List<HostInfo> newProxyNodes);

MetricDataHolder getMetricHolder();
}
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ public void run() {
// update proxy nodes meta configures
curTime = System.currentTimeMillis();
updateMetaInfoFromRemote(procResult);
if (configHolder != null && configHolder.getMetricHolder() != null) {
configHolder.getMetricHolder().addMetaSyncMetric(
procResult.getErrCode(), System.currentTimeMillis() - curTime);
}
if (shutDown.get()) {
break;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.inlong.sdk.dataproxy.metric;

import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.LongAdder;

public class MetaSyncInfo {

// meta error info
private final Map<Integer, LongAdder> syncErrInfo = new ConcurrentHashMap<>();
// msMs
private final TimeWastInfo syncWastMs = new TimeWastInfo("msMs");

public MetaSyncInfo() {
}

public void addSucMsgInfo(int errCode, long wastMs) {
LongAdder longCount = this.syncErrInfo.get(errCode);
if (longCount == null) {
LongAdder tmpCount = new LongAdder();
longCount = this.syncErrInfo.putIfAbsent(errCode, tmpCount);
if (longCount == null) {
longCount = tmpCount;
}
}
longCount.increment();
syncWastMs.addTimeWastMs(wastMs);
}

public void getAndResetValue(StringBuilder strBuff) {
if (syncErrInfo.isEmpty()) {
strBuff.append("\"mSync\":{\"errT\":{},");
syncWastMs.getAndResetValue(strBuff);
strBuff.append("}");
} else {
long curCnt = 0;
strBuff.append("\"metaSync\":{\"errT\":{");
for (Map.Entry<Integer, LongAdder> entry : syncErrInfo.entrySet()) {
if (curCnt++ > 0) {
strBuff.append(",");
}
strBuff.append("\"e").append(entry.getKey()).append("\":").append(entry.getValue());
}
strBuff.append("},");
syncWastMs.getAndResetValue(strBuff);
strBuff.append("}");
syncErrInfo.clear();
}
}

public void clear() {
syncWastMs.clear();
syncErrInfo.clear();
}
}
Loading
Loading