Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11397 Map Oak to expanded JCR name in NameMapper #1993

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

kwin
Copy link
Member

@kwin kwin commented Jan 16, 2025

No description provided.

@kwin kwin requested a review from reschke January 16, 2025 15:16
@kwin kwin marked this pull request as draft January 16, 2025 15:16
Copy link

github-actions bot commented Jan 16, 2025

Commit-Check ✔️

@kwin
Copy link
Member Author

kwin commented Jan 16, 2025

@reschke This is just a first step (i.e. for now just an SPI method) but I also found one glitch related to expanded names with empty namespace. Please have a look already.

@kwin kwin force-pushed the feature/generate-expanded-names branch 2 times, most recently from 209c94e to e3acbda Compare January 17, 2025 10:09
@kwin kwin force-pushed the feature/generate-expanded-names branch 2 times, most recently from 8985339 to 1b911c7 Compare January 17, 2025 12:03
@kwin kwin marked this pull request as ready for review January 17, 2025 15:40
@kwin kwin force-pushed the feature/generate-expanded-names branch from 1b911c7 to 54a10e1 Compare January 17, 2025 15:45
@kwin
Copy link
Member Author

kwin commented Jan 25, 2025

I am gonna merge end of January if there is no concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant