GH-2930: Support for query cancellation for spatial property functions #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aklakan
force-pushed
the
bugfix/spatial-cancel
branch
3 times, most recently
from
9a5c75f to
3d4fe06
Compare
Aklakan
force-pushed
the
bugfix/spatial-cancel
branch
5 times, most recently
from
0f9b4c1 to
e274a96
Compare
…ctions by creating iterators lazily.
Aklakan
force-pushed
the
bugfix/spatial-cancel
branch
from
e274a96 to
00e19cd
Compare
afs
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2930
Pull request Description: Improves base implementation of
GenericPropertyFunctionto operate lazily using theQueryItermachinery and its cancellation features. The classCancelQueryTesttests for successful cancellation.Disclaimer: The core work was done by my colleague @LorenzBuehmann - He suggested that I should take care of the PR.
Set to draft because perhaps some more regression testing should be added.There are several tests in the geosparql module. I experimented by introducing intentional errors into the PR, such as setting isSubjectBound hard to false/false or returning empty/unit result sets and they causes failures - so the tests already seem to sufficiently capture cases where bogus results are returned.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.