Improve set deletions percentage javadoc #12828
Conversation
| * Controls the maximum percentage of deleted documents that is tolerated in the index. Lower | ||
| * values make the index more space efficient at the expense of increased CPU and I/O activity. | ||
| * Values must be between 5 and 50. Default value is 20. | ||
| * Sets the maximum percentage of deleted documents that is tolerated in the index. The |
There was a problem hiding this comment.
Maybe it'll be great if we include what @jpountz defined it on the issue here as well since it was easier to understand...."how much of my doc ID space is taken by deleted docs" -> "percentage of doc id space taken by deleted docs". WDYT?
There was a problem hiding this comment.
Thanks for the review, I will modify the wording.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
It looks like this PR is in a bad state somehow? |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
@jpountz I have sync the fork. @shubhamvishu has already approved the commit. I will merge once the check passes. |
|
@jpountz It looks like I do not have push access to the repo. Can you help me merge it. Thanks! |
As a follow item of Discussion issue, improve the java doc to make the formula of deletion percentage clear to developers.