search on proper level when connecting graph components #13846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to backport to branch_10x? Could you also set the appropriate milestone? Thanks! |
msokolov
added a commit
that referenced
this pull request
Oct 3, 2024
|
thanks for the reminder - backported to 10x now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spinoff from #13844 but almost certainly not the cause; we're searching for close nodes to connect two graph components and searching level 0 even when connecting higher levels > 0. But the nodes we find should still be on the current level because of the filter we also apply, so this is just an efficiency fix