Adjust knn merge stability testing #14172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokolov
requested changes
Jan 28, 2025
| @@ -191,6 +193,9 @@ public PostingsFormat getPostingsFormatForField(String name) { | |||
| // Safety: | |||
| assert previousMappings.size() < 10000 : "test went insane"; | |||
| } | |||
| if (VERBOSE) { | |||
| System.out.println("RandomPostingsFormat: " + name + " -> " + codec); | |||
There was a problem hiding this comment.
Isn't System.out forbidden? Or is it OK in tests?
There was a problem hiding this comment.
Yeah, it's likely forbidden. I found this verbose output helpful in debugging. But I think it can be removed in preference to setting the info stream
I will fix up the PR and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new connected components work, merging is unstable. It generally seems that between indexing, there might be new connections as
vexindex size increases.I am not 100% sure the cause here. Opening this PR as one potential solution. Its interesting indeed that it occurs at all.
closes: #13640