-
Notifications
You must be signed in to change notification settings - Fork 69
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MNG-7965] Verify non-parseable POM is detected
- Loading branch information
Showing
3 changed files
with
115 additions
and
0 deletions.
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7965PomDuplicateTagsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.maven.it; | ||
|
||
import java.io.File; | ||
import java.util.List; | ||
|
||
import org.apache.maven.shared.verifier.VerificationException; | ||
import org.apache.maven.shared.verifier.Verifier; | ||
import org.apache.maven.shared.verifier.util.ResourceExtractor; | ||
import org.junit.jupiter.api.Test; | ||
|
||
/** | ||
* This is a test set for | ||
* <a href="https://issues.apache.org/jira/browse/MNG-7965">MNG-7965</a>. | ||
* Allow to exclude plugins from validation. Affected is Maven 4.0.0-alpha-9. | ||
*/ | ||
class MavenITmng7965PomDuplicateTagsTest extends AbstractMavenIntegrationTestCase { | ||
|
||
protected MavenITmng7965PomDuplicateTagsTest() { | ||
super("(,4.0.0-alpha-9),(4.0.0-alpha-9,)"); | ||
} | ||
|
||
@Test | ||
void javadocIsExecutedAndFailed() throws Exception { | ||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-7965-pom-duplicate-tags"); | ||
|
||
Verifier verifier = newVerifier(testDir.getAbsolutePath()); | ||
verifier.deleteDirectory("target"); | ||
verifier.addCliArgument("validate"); | ||
|
||
boolean invocationFailed = false; | ||
// whatever outcome we do not fail here, but later | ||
try { | ||
verifier.execute(); | ||
} catch (VerificationException e) { | ||
invocationFailed = true; | ||
} | ||
|
||
List<String> logs = verifier.loadLines(verifier.getLogFileName(), null); | ||
|
||
// the POM is not parseable | ||
verifyTextInLog(logs, "[FATAL] Non-parseable POM"); | ||
|
||
assertTrue("The Maven invocation should have failed: the POM is non-parseable", invocationFailed); | ||
} | ||
|
||
private void verifyTextInLog(List<String> logs, String text) { | ||
assertTrue("Log file not contains: " + text, logs.stream().anyMatch(l -> l.contains(text))); | ||
} | ||
|
||
private void verifyTextNotInLog(List<String> logs, String text) { | ||
assertFalse("Log file contains: " + text, logs.stream().anyMatch(l -> l.contains(text))); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
core-it-suite/src/test/resources/mng-7965-pom-duplicate-tags/pom.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
Licensed to the Apache Software Foundation (ASF) under one | ||
or more contributor license agreements. See the NOTICE file | ||
distributed with this work for additional information | ||
regarding copyright ownership. The ASF licenses this file | ||
to you under the Apache License, Version 2.0 (the | ||
"License"); you may not use this file except in compliance | ||
with the License. You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, | ||
software distributed under the License is distributed on an | ||
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
KIND, either express or implied. See the License for the | ||
specific language governing permissions and limitations | ||
under the License. | ||
--> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
|
||
<groupId>org.apache.maven.its.mng7965</groupId> | ||
<artifactId>test</artifactId> | ||
<version>1.0.0-SNAPSHOT</version> | ||
|
||
<repositories> | ||
<repository> | ||
<id>foo</id> | ||
<name>Bar</name> | ||
<url>https://really.does.not.matter/</url> | ||
</repository> | ||
</repositories> | ||
|
||
<repositories> | ||
<repository> | ||
<id>foo-other</id> | ||
<name>Bar The Other</name> | ||
<url>https://really.does.not.matter.either/</url> | ||
</repository> | ||
</repositories> | ||
|
||
</project> |