Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14228 Remove fallback Sensitive Properties Key from Commands #9691

Closed
wants to merge 1 commit into from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-14228 Removes the historical fallback Sensitive Properties Key from the set-sensitive-properties-key and set-sensitive-properties-algorithm commands, throwing an exception when it is not configured in nifi.properties.

This reflects the previous approach implemented for NiFi 1, before automatic key generation was implemented. NiFi 2 removed support for a blank Sensitive Properties Key, so these commands do not need to have the fallback value implemented.

Changes include updating unit tests to expect failures for a blank key.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory force-pushed the NIFI-14228 branch 3 times, most recently from 1ab187b to 7f7da82 Compare February 4, 2025 17:09
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @exceptionfactory and to make the build work on Windows!

@pvillard31 pvillard31 closed this in 26c98c5 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants