Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update defconfig #14283

Merged
merged 1 commit into from
Oct 15, 2024
Merged

update defconfig #14283

merged 1 commit into from
Oct 15, 2024

Conversation

lipengfei28
Copy link
Contributor

@lipengfei28 lipengfei28 commented Oct 15, 2024

arm64 update defconfig

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

@github-actions github-actions bot added Board: arm64 Size: S The size of the change in this PR is small labels Oct 15, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 15, 2024

[Experimental Bot, please feedback here]

The Pull Request you provided is missing crucial information to determine if it meets NuttX requirements.

Here's why:

  • Missing Context: "arm64 update defconfig" is too vague. We don't know what specific changes were made to the arm64 defconfig.
  • No Explanation: The Summary and Impact sections are left blank. You must explain the reason for the changes and their potential consequences on users, build processes, etc.
  • No Testing Details: The Testing section is empty. You need to list the specific build host (OS, compiler version) and target (board, configuration) you used to verify the changes. Ideally, provide logs from before and after the changes.

To meet NuttX requirements, the PR needs:

  1. Detailed Summary: Explain what was changed in the arm64 defconfig and why this change was necessary.
  2. Impact Assessment: Fill out each bullet point in the Impact section. Even if the answer is "NO", state it explicitly.
  3. Thorough Testing: Describe your testing environment and procedure in detail. Include relevant logs from before and after the change.

Without this information, it's impossible to assess if the PR meets NuttX standards.

Signed-off-by: lipengfei28 <[email protected]>
@GUIDINGLI GUIDINGLI merged commit 054257c into apache:master Oct 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: arm64 Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants