avoid variable length arrays #15577
avoid variable length arrays #15577
Conversation
use heap allocation instead. variable length array is a C99 feature, which should not be used in the common code. besides that, stack consumption with the unchecked user-given size a bad idea in general.
github-actions
bot
added
Area: Networking
|
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. SummaryThis PR lacks a summary. The author needs to provide information on the necessity of the change, the affected functional code, the mechanics of the change, and related NuttX issues/PRs. Without this, it's impossible to determine if it meets requirements. ImpactThe impact assessment is entirely missing. The author needs to address all listed impact areas (user, build, hardware, documentation, security, compatibility) with either "NO" or a "YES" followed by a description. Without this, the PR doesn't meet requirements. TestingThe testing section is incomplete. While the template is present, the author hasn't filled in any information about the build hosts, targets, or provided any testing logs before and after the change. This makes it impossible to assess if the changes work as intended and thus the PR does not meet the requirements. |
| @@ -142,9 +143,18 @@ static int do_sendto_request(FAR struct usrsock_conn_s *conn, | |||
| { | |||
| }; | |||
|
|
|||
| struct iovec bufs[2 + msg->msg_iovlen]; | |||
| struct iovec *bufs; | |||
| int i; | ||
|
|
||
| iovlen = 2 + msg->msg_iovlen; | ||
| bufs = kmm_malloc(sizeof(*bufs) * iovlen); |
There was a problem hiding this comment.
could we use alloca or save the buffer to conn? it isn't good to do the allocation in the hot path.
There was a problem hiding this comment.
i guess we can have a special case for small iovlen.
Summary
cf. #15572
Impact
Testing