-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nxgdb/irq: add irqinfo command #15743
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] Yes, this PR appears to mostly meet the NuttX requirements, but could be improved. Here's a breakdown: Strengths:
Weaknesses and Areas for Improvement:
Recommendation: To fully meet the requirements, fill in the missing details in the Impact and Testing sections. Provide concrete "before" and "after" logs demonstrating the change's functionality. Be as specific as possible about your build and target environments. Even if the answer is "NO" for most impact items, provide a brief justification. This makes the PR review much easier and increases the likelihood of it being accepted. |
5b85368
to
fddac21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add commit description
Could you add some information about this to the documentation website? Maybe here? |
fddac21
to
4a7f8ce
Compare
1. Add method to check if an object has specified field. 2. Fix Array iterator that walrus expression should store result of the function, instead of the compare result. Note that walrus operation has lowest priority except ','. Signed-off-by: xuxingliang <[email protected]>
(gdb) irqinfo IRQ COUNT TIME RATE HANDLER ARGUMENT 0 0 0 N/A mps_reserved 0x0 <sensor_unregister> 2 0 0 N/A mps_nmi 0x0 <sensor_unregister> 3 0 0 N/A arm_hardfault 0x0 <sensor_unregister> 4 0 0 N/A arm_memfault 0x0 <sensor_unregister> 5 0 0 N/A arm_busfault 0x0 <sensor_unregister> 6 0 0 N/A arm_usagefault 0x0 <sensor_unregister> 11 1 0 N/A arm_svcall 0x0 <sensor_unregister> 12 0 0 N/A arm_dbgmonitor 0x0 <up_debugpoint_remove> 14 0 0 N/A mps_pendsv 0x0 <up_debugpoint_remove> 15 6581421 0 N/A systick_interrupt 0x100010c <g_systick_lower> 49 2 0 N/A uart_cmsdk_tx_interrupt 0x1000010 <g_uart0port> 50 0 0 N/A uart_cmsdk_rx_interrupt 0x1000010 <g_uart0port> 59 2 0 N/A uart_cmsdk_ov_interrupt 0x1000010 <g_uart0port> (gdb) Signed-off-by: xuxingliang <[email protected]>
The NuttX GDB python plugin has been moved to tools/pynuttx/nxgdb. Update all documentation including this path. Signed-off-by: Neo Xu <[email protected]>
Add a table of commands we extend using GDB python API. Add irqinfo command documentation. Signed-off-by: Neo Xu <[email protected]>
4a7f8ce
to
2c93e0d
Compare
Done
Done, added to GDB with Python with a new table of commands. Currently only includes |
Hi @jerpelea , Please help to review the PR again. Thank you! |
Note: Please adhere to Contributing Guidelines.
Summary
Similar to nsh command,
irqinfo
shows the registered IRQ callbacks and arguements.Arguements is shown as a function when possible.
If intrumentation is enabled, it also prints the IRQ count etc.
Impact
New feature.
Testing
Tested with qemu live debugging.