Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS build error. #15774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cuiziweizw
Copy link
Contributor

Summary

  1. fix [BUG] macOS CI: sim:libcxxtest can't find cxxabi.h #14774.
    Change the defconfig of libcxxtest and select libcxxabi by default.

  2. fix [BUG] Mirror of NuttX: All macOS Jobs are broken #15491.
    libcxxabi cannot be used with uclibc, so when compiling macos sim, libcxxabi cannot be selected by default in Kconfig.

Impact

macos sim

Testing

ci test

@github-actions github-actions bot added Area: OS Components OS Components issues Board: simulator Size: XS The size of the change in this PR is very small labels Feb 6, 2025
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a proper commit message describing the fix

1. fix apache#14774.
Change the defconfig of libcxxtest and select libcxxabi by default to
fix sim:libcxxtest build in macOS CI can't find cxxabi.h.

2. fix apache#15491.
libcxxabi cannot be used with uclibc, so when compiling macos sim, libcxxabi cannot be selected by default in Kconfig.

Signed-off-by: cuiziwei <[email protected]>
@cuiziweizw
Copy link
Contributor Author

please add a proper commit message describing the fix

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Board: simulator Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mirror of NuttX: All macOS Jobs are broken [BUG] macOS CI: sim:libcxxtest can't find cxxabi.h
3 participants