ORC-1841: [C++][CI] Add UBSAN support to Cmake #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Jan 20, 2025
.github/workflows/ubsan_test.yml
Outdated
| CXX: ${{ matrix.cxx }} | ||
| run: | | ||
| mkdir build && cd build | ||
| cmake .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_UBSAN=ON -DBUILD_JAVA=OFF |
There was a problem hiding this comment.
Can we enable ASan and UBSan in the same workflow?
ffacs
reviewed
Jan 21, 2025
.github/workflows/ubsan_test.yml
Outdated
| CXX: ${{ matrix.cxx }} | ||
| run: | | ||
| mkdir build && cd build | ||
| cmake .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_UBSAN=ON -DBUILD_JAVA=OFF |
There was a problem hiding this comment.
Maybe we should turn on following options:
-DBUILD_ENABLE_AVX512=ON -DBUILD_CPP_ENABLE_METRICS=ON
There was a problem hiding this comment.
Why do we need to collect metrics in a CI workflow?
There was a problem hiding this comment.
Why do we need to collect metrics in a CI workflow?
There are some codes only enabled when the macroENABLE_METRICS is defined, we need to check them too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for UBASN in CMake options and enable it by default in the CI workflow.
Why are the changes needed?
Detect undefined behavior issues with the help of the undefined sanitizer.
How was this patch tested?
Pass all CIs.
Was this patch authored or co-authored using generative AI tooling?
NO.