Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
devabhishekpal committed Jan 16, 2025
1 parent 45e9b69 commit 36a7eb1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Prepopulate Data and Trigger OM DB Sync
[Documentation] Use Freon to prepopulate the OM DB with data and trigger OM DB sync.
Kinit as ozone admin
Freon DFSG n=1000 path=${KEYPATH}
Freon DFSG n=100 path=${KEYPATH}

Sync OM Data

Expand Down Expand Up @@ -103,9 +103,7 @@ Validate All Tasks Updated After Sync
END

Validate Sequence number is updated after sync
Log To Console Generating Freon Data
Kinit as ozone admin
Freon DFSG n=100 path=${VOLUME}/${BUCKET}/seqValidationKey
Log To Console Syncing OM DB to ensure all updates are applied
Sync OM Data

${tasks} = Fetch Task Status
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,7 @@ void getAndApplyDeltaUpdatesFromOM(
inLoopStartSequenceNumber = inLoopLatestSequenceNumber;
loopCount++;
}
// We might reach loop count limit and so not all updates from RocksDB might be applied.
// Say we have: 1000 updates, each loop we get only 100 updates, loop limit is 5.
// So this will effectively only apply 500 events, even if we are having total 1000 updates/events;
// All subsequent tasks will effectively process only 500 events, till next sync takes place.

omdbUpdatesHandler.setLatestSequenceNumber(getCurrentOMDBSequenceNumber());
LOG.info("Delta updates received from OM : {} loops, {} records", loopCount,
getCurrentOMDBSequenceNumber() - fromSequenceNumber
Expand Down Expand Up @@ -544,8 +541,8 @@ boolean innerGetAndApplyDeltaUpdatesFromOM(long fromSequenceNumber,
* <li>Initially it will fetch a snapshot of OM DB.</li>
* <li>If we already have data synced it will try to fetch delta updates.</li>
* <li>If the sync is completed successfully it will trigger other OM tasks to process events</li>
* <li>If there is any exception while trying to fetch delta updates, it will fall back to snapshot update</li>
* <li>If there is any exception in snapshot sync it will do nothing.</li>
* <li>If there is any exception while trying to fetch delta updates, it will fall back to full snapshot update</li>
* <li>If there is any exception in full snapshot update it will do nothing, and return true.</li>
* <li>In case of an interrupt signal (irrespective of delta or snapshot sync),
* it will catch and mark the task as interrupted, and return false i.e. sync failed status.</li>
* </ul>
Expand Down

0 comments on commit 36a7eb1

Please sign in to comment.