HDDS-11603. Reclaimable Filter for Snapshots garbage reclaimation #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I34b91e11970c9cd785ba863dd22a4081244cede6
swamirishi
changed the title
Change-Id: I5dbb017343b5a666c56d53af2839dcb340fdf0ba
Change-Id: I67de73438c7ebc37c3d6e44bfe6e09188fb537e1
Change-Id: Ie80cd2191504e3a5ebd1cb21d04d300dc0c22ef9
Change-Id: If027d4ac4c5171ded3499b900909347d59406f36
Change-Id: I7fe6d4029abe5917e20bb82ae1b2494e2319da70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have implemented the key reference check for snapshots in multiple places in different manner for snapshot garbage collection. There is a need to consolidate this reference check in one central place in order to avoid bugs and for better debuggability & for making the whole garbage collection more modular than it is. Currently the Garbage collection code is tightly coupled with snapshots, making it really tough for people to understand. We should move this code out to a different module making the garbage collection flow more readable.
To keep the patch size limited, the classes added are not used by any of the flows. I would be creating a follow up patches on top of this change.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11603
How was this patch tested?
Unit Tests