HDDS-6931. Support for serialized pre-process validators #7698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
November 27, 2024 16:51
This reverts commit 62ef090.
…CreateBucketPermissionDenied
adoroszlai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-6931. Support for serialized pre-process validators.
@duongkame in the HDDS-6931 mentioned:
"I think pre-process validation should only perform logic on data which is not supposed to change between pre-process and actual execution in validateAndUpdateCache. Otherwise, that validation should be moved to {{validateAndUpdateCache, }}and is done together with the real data change in a proper lock scope to ensure consistency."
What is the link to the Apache JIRA
HDDS-6931.
How was this patch tested?
Unit tests passed.
Questions:
auditLogif a request fails inpreExecute, but not in thevalidateAndUpdateCache?volumeNameandbucketNamein methodpreExecuteinstead of methodvalidateAndUpdateCachein class OMKeysRenameRequest? this could be done by putting these variables as Proto request fields.