Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12093. Exclude generated code when verifying import restrictions #7709

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Stop spending time analyzing generated code when validating import restrictions. Saves around 6 seconds, which is not much for a normal build, but about 10% for local build when skipping tests.

https://issues.apache.org/jira/browse/HDDS-12093

How was this patch tested?

mvn -DskipShade -DskipTests -Dskip.installnodenpm -Dskip.npx

Before:

[INFO] Apache Ozone HDDS Client Interface ................. SUCCESS [  5.458 s]
[INFO] Apache Ozone HDDS Admin Interface .................. SUCCESS [  1.606 s]
[INFO] Apache Ozone HDDS Server Interface ................. SUCCESS [  2.077 s]
[INFO] Apache Ozone Client Interface ...................... SUCCESS [ 11.998 s]
[INFO] Apache Ozone Storage Interface ..................... SUCCESS [  0.367 s]

After:

[INFO] Apache Ozone HDDS Client Interface ................. SUCCESS [  3.858 s]
[INFO] Apache Ozone HDDS Admin Interface .................. SUCCESS [  1.109 s]
[INFO] Apache Ozone HDDS Server Interface ................. SUCCESS [  1.481 s]
[INFO] Apache Ozone Client Interface ...................... SUCCESS [  7.201 s]
[INFO] Apache Ozone Storage Interface ..................... SUCCESS [  0.421 s]

CI:
https://github.com/adoroszlai/ozone/actions/runs/12805099339

@adoroszlai adoroszlai added the build Pull request that modifies the build process label Jan 16, 2025
@adoroszlai adoroszlai self-assigned this Jan 16, 2025
@adoroszlai adoroszlai changed the title HDDS-12093. Exclude generated code for import restrictions HDDS-12093. Exclude generated code when verifying import restrictions Jan 19, 2025
@nandakumar131
Copy link
Contributor

@adoroszlai, a big +1 for all these improvements.

Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@nandakumar131 nandakumar131 merged commit ce82d12 into apache:master Jan 20, 2025
42 checks passed
@nandakumar131
Copy link
Contributor

Thanks @adoroszlai for the contribution!

@adoroszlai adoroszlai deleted the HDDS-12093 branch January 20, 2025 06:58
@adoroszlai
Copy link
Contributor Author

Thanks a lot @nandakumar131 for reviewing and merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Pull request that modifies the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants