Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12162. Log available space of HddsVolume and DbVolume upon Datanode startup #7777

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

smengcl
Copy link
Contributor

@smengcl smengcl commented Jan 29, 2025

What changes were proposed in this pull request?

This aims to provide slightly more info to identify issues like completely full volumes.

Related: HDDS-12151 and HDDS-12150.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12162

How was this patch tested?

  • Verified in the test output that available (and used) space is now printed. e.g.:

  • TestHddsVolume#testOverUsedReservedSpace:

2025-01-29 15:35:02,159 [main] INFO  volume.HddsVolume (HddsVolume.java:<init>(134)) - Creating HddsVolume: /var/folders/ns/ls79bcr17wg7r__2j8lqkz6m0000gn/T/junit-8615142427860431562/hdds of storage type: null, capacity=400, used=0, available=300
  • TestHddsVolume#testOverUsedHddsSpace:
2025-01-29 15:35:02,388 [main] INFO  volume.HddsVolume (HddsVolume.java:<init>(134)) - Creating HddsVolume: /var/folders/ns/ls79bcr17wg7r__2j8lqkz6m0000gn/T/junit-3498499940805584038/hdds of storage type: null, capacity=400, used=450, available=0

@smengcl smengcl requested a review from ashishkumar50 January 29, 2025 19:37
@smengcl smengcl self-assigned this Jan 29, 2025
@adoroszlai adoroszlai changed the title HDDS-12162. Log print available space of HddsVolume upon Ozone Datanode startup HDDS-12162. Log available space of HddsVolume upon Datanode startup Jan 29, 2025
@smengcl smengcl changed the title HDDS-12162. Log available space of HddsVolume upon Datanode startup HDDS-12162. Log available space of HddsVolume and DbVolume upon Datanode startup Jan 29, 2025
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smengcl for updating the patch.

Copy link
Contributor

@ashishkumar50 ashishkumar50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smengcl, Thanks for the patch, LGTM.

@adoroszlai adoroszlai merged commit c7872f7 into apache:master Jan 30, 2025
42 checks passed
@adoroszlai
Copy link
Contributor

Thanks @smengcl for the patch, @ashishkumar50 for the review.

@smengcl
Copy link
Contributor Author

smengcl commented Jan 30, 2025

Thanks @adoroszlai and @ashishkumar50 for reviewing the patch!

nandakumar131 pushed a commit to nandakumar131/ozone that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants