-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slick - Add slick flow functions with error handling using try. #949
Slick - Add slick flow functions with error handling using try. #949
Conversation
My preference would be not to change the 'Slick' object. Could you just create just create a 2nd 'SlickWithTryResult' or something like that? |
Absolutely. That's my first implementation, but later settled with this. I will change it. |
7f399c7
to
e63253d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with both new files, they are based on existing files and they should use the source headers from those files - so can you replace the source headers in your new files with
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* license agreements; and to You under the Apache License, version 2.0:
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* This file is part of the Apache Pekko project, which was derived from Akka.
*/
/*
* Copyright (C) since 2016 Lightbend Inc. <https://www.lightbend.com>
*/
@pjfanning file headers updated. Thank you for pointing that out. |
the test code doesn't compile in scala 2.12
|
I have committed some code changes but I'm not sure if they work yet. |
seeing test failure in |
slick/src/test/scala/docs/scaladsl/SlickWithTryResultSpec.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - lgtm
No description provided.