Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky JdbcProjectionTest #108

Merged
merged 4 commits into from
Mar 15, 2024
Merged

fix flaky JdbcProjectionTest #108

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9b0352
fix flaky JdbcProjectionTest
Roiocam Feb 20, 2024
ba16656
code fmt
Roiocam Feb 20, 2024
34f7d43
block until element arrived
Roiocam Feb 20, 2024
be89dfd
additional block for exactlyOnce
Roiocam Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions jdbc/src/test/java/org/apache/pekko/projection/jdbc/JdbcProjectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@
import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.function.Predicate;
import java.util.function.Supplier;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

public class JdbcProjectionTest extends JUnitSuite {

Expand Down Expand Up @@ -209,13 +211,14 @@ private void expectNextUntilErrorMessage(TestSubscriber.Probe<Done> probe, Strin
}

private JdbcHandler<Envelope, PureJdbcSession> concatHandler(StringBuffer str) {
return concatHandler(str, __ -> false);
return concatHandler(str, new CountDownLatch(0), __ -> false);
}

private JdbcHandler<Envelope, PureJdbcSession> concatHandler(
StringBuffer buffer, Predicate<Long> failPredicate) {
StringBuffer buffer, CountDownLatch latch, Predicate<Long> failPredicate) {
return JdbcHandler.fromFunction(
(PureJdbcSession session, Envelope envelope) -> {
latch.countDown();
if (failPredicate.test(envelope.offset)) {
throw new RuntimeException(failMessage(envelope.offset));
} else {
Expand Down Expand Up @@ -275,21 +278,23 @@ public void exactlyOnceShouldRestartFromPreviousOffset() {
ProjectionId projectionId = genRandomProjectionId();

StringBuffer str = new StringBuffer();
CountDownLatch latch = new CountDownLatch(3);

Projection<Envelope> projection =
JdbcProjection.exactlyOnce(
projectionId,
sourceProvider(entityId),
jdbcSessionCreator,
// fail on fourth offset
() -> concatHandler(str, offset -> offset == 4),
() -> concatHandler(str, latch, offset -> offset == 4),
testKit.system());

projectionTestKit.runWithTestSink(
projection,
(probe) -> {
probe.request(3);
probe.expectNextN(3);
assertTrue(latch.await(3, TimeUnit.SECONDS));
assertEquals("abc|def|ghi|", str.toString());
expectNextUntilErrorMessage(probe, failMessage(4));
});
Expand Down Expand Up @@ -326,14 +331,15 @@ public void atLeastOnceShouldRestartFromPreviousOffset() {
ProjectionId projectionId = genRandomProjectionId();

StringBuffer str = new StringBuffer();
CountDownLatch latch = new CountDownLatch(3);

Projection<Envelope> projection =
JdbcProjection.atLeastOnce(
projectionId,
sourceProvider(entityId),
jdbcSessionCreator,
// fail on fourth offset
() -> concatHandler(str, offset -> offset == 4),
() -> concatHandler(str, latch, offset -> offset == 4),
testKit.system())
.withSaveOffset(1, Duration.ZERO);

Expand All @@ -348,6 +354,7 @@ public void atLeastOnceShouldRestartFromPreviousOffset() {
*/
probe.request(2);
probe.expectNextN(2);
assertTrue(latch.await(3, TimeUnit.SECONDS));
assertEquals("abc|def|ghi|", str.toString());
expectNextUntilErrorMessage(probe, failMessage(4));
});
Expand Down
Loading