Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade slick and logback dependencies #123

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Mar 23, 2024

I think we will need to upgrade these together because Slick needs slf4jv2 compliant logback

@pjfanning pjfanning changed the title upgrade test dependencies upgrade slick and logback dependencies Apr 7, 2024
@pjfanning
Copy link
Contributor Author

@raboof @mdedetrich this PR works while the scala steward split ones don't

This was referenced Apr 7, 2024
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why, they have to be updated together.

lgtm

@pjfanning pjfanning merged commit 39a8f37 into apache:main Apr 7, 2024
28 checks passed
@pjfanning pjfanning deleted the test-deps branch April 7, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants