Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring persistence plugins at runtime for EventSourcedProvider #225

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

ptrdom
Copy link
Member

@ptrdom ptrdom commented Oct 21, 2024

Pending release of apache/pekko#1518.

@pjfanning
Copy link
Contributor

pjfanning commented Oct 21, 2024

@raboof @mdedetrich I'm ok with this despite it meaning that pekko-projection 1.1.0 would rely on a future pekko (core) 1.1.3 release - this can be documented.

We are a while away from being able to release pekko-projection 1.1.0 as we need pekko-connectors 1.1.0 released first. And we could do a Pekko (Core) 1.1.3 release in the mean time. I know it is not ideal to have some new features in Pekko (Core) 1.1.3 but I think it would too painful to call this a 1.2.0 release.

@pjfanning
Copy link
Contributor

Some compile issues. eg

[info] compiling 16 Scala sources and 1 Java source to /home/runner/work/pekko-projection/pekko-projection/core-test/target/scala-2.13/test-classes ...
[error] /home/runner/work/pekko-projection/pekko-projection/eventsourced/src/test/scala/org/apache/pekko/projection/eventsourced/scaldsl/EventSourcedProviderSpec.scala:48:71: private default argument in object EventSourcedProviderSpec is never used
[error]   private def testBehaviour(persistenceId: String, tags: Set[String], maybeJournal: Option[String] = None) = {
[error]                                                                       ^
[error] one error found

@pjfanning
Copy link
Contributor

scala 2.12 compile issues

@pjfanning
Copy link
Contributor

@ptrdom do you think this ready for merge? Pekko 1.1.3 is released.

@ptrdom
Copy link
Member Author

ptrdom commented Jan 8, 2025

@pjfanning Yes, LGTM! 🚀

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 3dc9f5a into apache:main Jan 9, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants