Add git repo as a top-level menu #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
eric-maynard,
collado-mike and
ebyhr
as code owners
flyrain
commented
Oct 6, 2024
| - name: "Docs & Releases" | ||
| identifier: "releases" | ||
| weight: 800 | ||
| weight: 100 |
There was a problem hiding this comment.
Make "docs & releases" the first menu item.
flyrain
commented
Oct 6, 2024
site/layouts/partials/navbar.html
Outdated
| </ul> | ||
| </div> | ||
| {{ else }} | ||
| <!-- Menu items without children --> |
There was a problem hiding this comment.
Add the logic for menu items without children. Other changes in this PR are mainly formatting.
There was a problem hiding this comment.
Can you remove all the formatting changes? It's a bit hard to see the actual differences.
There was a problem hiding this comment.
Hi @snazy , removed the formatting changes. Can you take another look?
flyrain
force-pushed
the
add-github-menu
branch
from
c9f39bd to
3f74bf8
Compare
snazy
approved these changes
Oct 15, 2024
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Local test works as the following screenshot shows.
Checklist:
Please delete options that are not relevant.