Add the missing parts (code coming from other projects) in LICENSE & NOTICE #903
Conversation
jbonofre
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
jbonofre
force-pushed
the
rc5-prep-license-fix
branch
2 times, most recently
from
b092bbc to
d746f9a
Compare
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| This product includes code from Project Nessie. |
There was a problem hiding this comment.
Were these not contributed to the project by Dremio employees? If that's the case, then I think the regular contribution rules would apply, even if the code is present in another project. It doesn't matter that it was originally in another project, it matters that it was directly contributed by the copyright owner. If the copyright owner was not the one to contribute, then the third-party documentation would be needed.
There was a problem hiding this comment.
But, I don't know if we are talking about the same original authors. @snazy can you confirm that you are the author of the original files ? or do we have other dremio contributors on these files ?
There was a problem hiding this comment.
There are multiple authors on this code
There was a problem hiding this comment.
There was a problem hiding this comment.
Side note: gradle/wrapper/gradle-wrapper.properties is a generated file, not "copied" from anywhere.
There was a problem hiding this comment.
I guess it's fine to treat it as a third-party contribution if the attribution is unknown from the Nessie project.
I'm actually more concerned right now about the GPL reference that popped up in the Iceberg NOTICE changes.
There was a problem hiding this comment.
I checked and it's dual license: CDDL + GPL or GPL + EPL.
I checked in https://github.com/projectnessie/nessie/releases/download/nessie-0.102.2/nessie-aggregated-license-report-0.102.2.zip
It would be great if Nessie clarify in the NOTICE.
@rdblue thoughts ?
There was a problem hiding this comment.
I've updated Nessie NOTICE with the 0.102.5 version.
NOTICE
Outdated
| Copyright 2017-2025 The Apache Software Foundation | ||
|
|
||
| Dremio | ||
| Copyright 2015-2017 Dremio Corporation |
There was a problem hiding this comment.
This addition depends on whether the code was contributed or copied as third-party content. My understanding is that it was contributed directly by Dremio and this should not be present.
There was a problem hiding this comment.
Correct, I asked the question on the other comment.
There was a problem hiding this comment.
@jbonofre I think we need to verify that there is no GPL code in here, given the mention of GPL code in the NOTICE updates to Iceberg.
There was a problem hiding this comment.
@rdblue yup. That's a concern to me too. Let me check.
There was a problem hiding this comment.
I checked and it's dual license: CDDL + GPL or GPL + EPL.
I checked in https://github.com/projectnessie/nessie/releases/download/nessie-0.102.2/nessie-aggregated-license-report-0.102.2.zip
It would be great if Nessie clarify in the NOTICE.
There was a problem hiding this comment.
I've updated Nessie NOTICE with the 0.102.5 version.
jbonofre
force-pushed
the
rc5-prep-license-fix
branch
from
d746f9a to
eb4ed52
Compare
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to apache#903
To ensure that files that are known to be mentioned in `LICENSE` are really mentioned in that file, the Gradle plugin introduced in this change verifies this. The "magic word" `CODE_COPIED_TO_POLARIS` must be present in such files. The presence of the "magic word" triggers a validation that the path of the containing file, relative to the project root directory, must be mentioned in `LICENSE`, prefixed with `* `. The plugin checks all source directories in projects that have any Java plugin applied. For other projects, the plugin's extension provides a mechanism to add directory sets similar to how `SourceDirectorySet` works, which is used for the root project. The plugin must be applied on the root project, it adds itself to all other projects. The introduced `checkForCopiedCode` task is added to the `check` task as a dependency. Files that contain "copied code" need to have the word `CODE_COPIED_TO_POLARIS` anywhere. Related to #903
jbonofre
force-pushed
the
rc5-prep-license-fix
branch
from
eb4ed52 to
bf7910e
Compare
|
I updated Nessie @rdblue do you mind to do a new pass ? Thanks ! |
jbonofre
force-pushed
the
rc5-prep-license-fix
branch
from
bf7910e to
00cf110
Compare
|
I think we are good now. I propose to merge this PR and I will submit rc5 to vote. |
jbonofre
force-pushed
the
rc5-prep-license-fix
branch
from
00cf110 to
7713909
Compare
This PR adds the missing parts in LICENSE/NOTICE found in 0.9.0 rc4.
@rdblue @snazy