Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg API YAML #935

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

HonahX
Copy link
Contributor

@HonahX HonahX commented Feb 4, 2025

This PR is the first follow-up of #906

Updated the website's reference to generated/bundled-polaris-catalog-service.yaml instead of rest-catalog-open-api.yaml. This change ensures that Polaris-native APIs and models can be removed from rest-catalog-open-api.yaml in the next step, allowing it to align with the released version.

cc: @flyrain @jackye1995

weight: 900
params:
show_page_toc: false
---

{{< redoc-polaris "rest-catalog-open-api.yaml" >}}
{{< redoc-polaris "generated/bundled-polaris-catalog-service.yaml" >}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A preview of the current page
Screenshot 2025-02-03 at 5 41 28 PM

@HonahX HonahX changed the title Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg File Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg API YAML Feb 4, 2025
Copy link

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@flyrain flyrain merged commit 3685065 into apache:main Feb 4, 2025
5 checks passed
@flyrain
Copy link
Contributor

flyrain commented Feb 4, 2025

Thanks @HonahX for the fix, and @jackye1995 for the review.

@HonahX
Copy link
Contributor Author

HonahX commented Feb 4, 2025

Hi @flyrain Could you please help me revert this one? It works locally but breaks the published website:

polaris-management-service/:1 Refused to load the script 'https://cdn.jsdelivr.net/npm/redoc@latest/bundles/redoc.standalone.js' because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-inline' 'unsafe-eval' https://analytics.apache.org/". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.
Refused to load the script 'https://cdn.jsdelivr.net/npm/redoc@latest/bundles/redoc.standalone.js' because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-inline' 'unsafe-eval' https://analytics.apache.org/". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.

So both management api and catalog api page fails to be rendered :(

HonahX added a commit to HonahX/polaris that referenced this pull request Feb 4, 2025
flyrain pushed a commit that referenced this pull request Feb 4, 2025
@sfc-gh-ygu
Copy link
Contributor

Hi @jbonofre , the reverting doesn't work as well. Is there any change from Apache Infra so that the website put more security limit?

polaris-management-service/:1 Refused to load the script 'https://cdn.jsdelivr.net/npm/redoc@latest/bundles/redoc.standalone.js' because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-inline' 'unsafe-eval' https://analytics.apache.org/". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.

mlsstart pushed a commit to mlsstart/polaris that referenced this pull request Feb 8, 2025
mlsstart pushed a commit to mlsstart/polaris that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants