-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Fix update response body text #18794
[fix][client] Fix update response body text #18794
Conversation
@tuteng Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, We need to see if we break unit test.
Codecov Report
@@ Coverage Diff @@
## master #18794 +/- ##
============================================
- Coverage 44.79% 37.16% -7.63%
+ Complexity 10026 6977 -3049
============================================
Files 703 623 -80
Lines 68808 59099 -9709
Branches 7375 6146 -1229
============================================
- Hits 30822 21967 -8855
+ Misses 34378 34294 -84
+ Partials 3608 2838 -770
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Can you give an actual case this PR is solving? |
This needs an interceptor and then throws an exception with a custom message, using pulsar-admin to execute the corresponding command, which never gets the custom message @Jason918 |
Oops. Could you help to take a look? I am not sure if it is a sensitive breaking change for users. |
Fixes #xyz
Master Issue: #xyz
Motivation
When using pulsar-admin and encountering an exception, first check the body, then check the http text
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: AmateurEvents#31