Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RANGER-5017: updated sources to address 'may produce NullPointerException' warning, and remove unnecessary generic parameters #515

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mneethiraj
Copy link
Contributor

What changes were proposed in this pull request?

Updated sources to address following warnings/suggestions from IDE:

  • may produce NullPointerException
  • remove unnecessary generic parameters

How was this patch tested?

Build with unit tests completed successfully.

…tion' warning, and remove unnecessary generic parameters
Copy link
Contributor

@vyommani vyommani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. However, I do have a question: were the changes made manually, or did you update the code style plugin to use the diamond operator (<>) and perform null checks manually?

@mneethiraj
Copy link
Contributor Author

The code changes look good to me. However, I do have a question: were the changes made manually, or did you update the code style plugin to use the diamond operator (<>) and perform null checks manually?

IDE (IntellJ) flags potential NPE warnings, and suggests using <> operator while instantiating generic types. Tjese changes will need to be made manually though.

@mneethiraj mneethiraj merged commit 8f9bedf into apache:master Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants