RANGER-5153: fix for intermittent unit test failure in RangerJSONAuditWriterTest #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
requested review from
rameeshm,
kulkabhay,
pradeepagrawal8184,
vperiasamy,
fateh288,
kumaab,
kishorgollapalliwar,
maheshbandal15,
dineshkumar-yadav and
spolavarpau1
vyommani
reviewed
Feb 22, 2025
| if (CollectionUtils.isEmpty(events)) { | ||
| closeFileIfNeeded(); | ||
| } else { | ||
| out1 = getLogFileStream(); |
There was a problem hiding this comment.
you can reduce the scope of out1 to else block .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test checks for null value for AbstractRangerAuditWriter.logWriter in the main test thread. This member is updated in antoher thread that periodically looks to close the audit file. AbstractRangerAuditWriter.logWriter is now made vollatile so that updated value is visible in the main test thread.
How was this patch tested?
Build with unit tests completed successfully.